Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: None
    • Component/s: core/search
    • Labels:
      None
    • Environment:

      All

    • Lucene Fields:
      New, Patch Available

      Description

      Filters and caching uses transient maps so that caching does not work if you are using RMI and a remote searcher

      I want to add a new RemoteCachededFilter that will make sure that the caching is done on the remote searcher side

      1. RemoteCachingWrapperFilter.patch .patch
        21 kB
        Matt Ericson
      2. RemoteCachingWrapperFilter.patch
        16 kB
        Matt Ericson
      3. RemoteCachingWrapperFilter.patch
        22 kB
        Matt Ericson
      4. RemoteCachingWrapperFilter.patch
        22 kB
        Otis Gospodnetic

        Activity

        Matt Ericson created issue -
        Hide
        Matt Ericson added a comment -

        This is a patch that will allow uses to cache Filters even when using RMI

        Show
        Matt Ericson added a comment - This is a patch that will allow uses to cache Filters even when using RMI
        Matt Ericson made changes -
        Field Original Value New Value
        Attachment RemoteCachingWrapperFilter.patch [ 12354622 ]
        Hide
        Matt Ericson added a comment -

        This is new and better version of my Lucene patch

        Show
        Matt Ericson added a comment - This is new and better version of my Lucene patch
        Matt Ericson made changes -
        Attachment RemoteCachingWrapperFilter.patch [ 12354648 ]
        Hide
        Matt Ericson added a comment -

        A new version that will hopefully patch more correctly

        Show
        Matt Ericson added a comment - A new version that will hopefully patch more correctly
        Matt Ericson made changes -
        Attachment RemoteCachingWrapperFilter.patch .patch [ 12354949 ]
        Hide
        Otis Gospodnetic added a comment -

        Nice. Unit tests pass and caching seems to work.
        I'll make some small javadoc and cosmetic fixes, upload the prettified patch and commit on Friday.

        This will give 2 more days to others to review your changes and raise any issues they may see.

        Show
        Otis Gospodnetic added a comment - Nice. Unit tests pass and caching seems to work. I'll make some small javadoc and cosmetic fixes, upload the prettified patch and commit on Friday. This will give 2 more days to others to review your changes and raise any issues they may see.
        Hide
        Matt Ericson added a comment -

        Thanks

        Matt

        Show
        Matt Ericson added a comment - Thanks Matt
        Hide
        Otis Gospodnetic added a comment -

        Here is a cleaned up version.

        • Changed CachingWrapperFilter - private -> protected vars, so CachingWrapperFilterHelper can extend it
        • Expanded unit tests to be more convincing
        • Javadocs all fixed up + cosmetics + code comments

        n.b.
        The @todo in CachingWrapperFilter can go now:
        /**

        • @todo What about serialization in RemoteSearchable? Caching won't work.
        • Should transient be removed?
          */
          protected transient Map cache;

        We keep the transient, and if you want remote caching, use RemoteCachingWrapperFilter.

        I'll commit on Friday.

        Show
        Otis Gospodnetic added a comment - Here is a cleaned up version. Changed CachingWrapperFilter - private -> protected vars, so CachingWrapperFilterHelper can extend it Expanded unit tests to be more convincing Javadocs all fixed up + cosmetics + code comments n.b. The @todo in CachingWrapperFilter can go now: /** @todo What about serialization in RemoteSearchable? Caching won't work. Should transient be removed? */ protected transient Map cache; We keep the transient, and if you want remote caching, use RemoteCachingWrapperFilter. I'll commit on Friday.
        Otis Gospodnetic made changes -
        Attachment RemoteCachingWrapperFilter.patch [ 12354959 ]
        Otis Gospodnetic made changes -
        Lucene Fields [New] [New, Patch Available]
        Hide
        Otis Gospodnetic added a comment -

        Committed, thanks Matt.

        Show
        Otis Gospodnetic added a comment - Committed, thanks Matt.
        Otis Gospodnetic made changes -
        Resolution Fixed [ 1 ]
        Lucene Fields [Patch Available, New] [New, Patch Available]
        Status Open [ 1 ] Resolved [ 5 ]
        Mark Thomas made changes -
        Workflow jira [ 12400709 ] Default workflow, editable Closed status [ 12564550 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12564550 ] jira [ 12584955 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Matt Ericson
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development