Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8437

CheckIndex should not duplicate SegmentInfos serialization

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.5, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      CheckIndex tries to read the segments file to provide more information about the problem, but it gets almost everything wrong: it reads an int which based on comments and error messages is either the format or the version but this is actually the magic number of the codec header. It looks like this code is about10 years old and hasn't been updated when we added checksums to index files. SegmentInfos does a better job at detecting issues nowadays, so these manual checks can be removed.

        Attachments

        1. LUCENE-8437.patch
          2 kB
          Adrien Grand

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jpountz Adrien Grand
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: