Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8424

Payload null value exception handling

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 7.2, 7.3.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    • Review Patch?:
      Yes

      Description

      If-Condition to check payload null value in PayloadScoreQuery.java was removed in LUCENE-8038. Because of that, regarding of the payload value, payloadsSeen is always getting increment. This has compromised the overall score of the document(for instance, as payloadSeens is always greater than 0, docScore() in MinPayloadFunction.java only returns payloadScore which can be zero depending on the payload value). Ideally, it should've returned 1 in case of payload==null.

      I have added a simple patch to get started, Please let me know if it needs any improvements. 
      Thanks in advance.

        Attachments

        1. LUCENE-8424.patch
          5 kB
          Tapan Vaishnav
        2. LUCENE-8424.patch
          5 kB
          Tapan Vaishnav
        3. LUCENE-8424.patch
          5 kB
          Tapan Vaishnav
        4. LUCENE-8424.patch
          5 kB
          Tapan Vaishnav
        5. LUCENE-8424.patch
          5 kB
          Tapan Vaishnav
        6. LUCENE-8424.patch
          6 kB
          Tapan Vaishnav
        7. LUCENE-8424.patch
          1 kB
          Tapan Vaishnav

          Activity

            People

            • Assignee:
              romseygeek Alan Woodward
              Reporter:
              tvaishna Tapan Vaishnav
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: