Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8324

Unreferenced files of dropped segments should be released

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.4, 8.0
    • Fix Version/s: None
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This has the side-effect that flushed segments that are 100% hard deleted are also
      cleaned up right after they are flushed, previously these segments were sticking
      around for a while until they got picked for a merge or received another delete.

      Since LUCENE-8253, a fully deleted segment is dropped immediately when it's flushed, however, its files might be kept around even after a commit. In other words, we may have unreferenced files which are retained by Deleter.

      I am not entirely sure if we should fix this but it's nice to have a consistent content between current files and commit points as before.

      I attached a failed test for this.

      /cc Simon Willnauer

        Attachments

        1. LUCENE-8324.patch
          3 kB
          Simon Willnauer
        2. release-files.patch
          1 kB
          Nhat Nguyen

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dnhatn Nhat Nguyen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: