Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8296

PendingDeletes shouldn't write to live docs that it shared

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      PendingDeletes has a markAsShared mechanism that allow to make sure that the latest livedocs are not going to receive more updates. But it is not always used, and I was able to verify that in some cases we end up with readers whose live docs disagree with the number of deletes. Even though this might not be causing bugs, it feels dangerous to me so I think we should consider always marking live docs as shared in #getLiveDocs.

        Attachments

        1. LUCENE-8296.patch
          10 kB
          Adrien Grand

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jpountz Adrien Grand
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: