Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8290

Keep soft deletes in sync with on-disk DocValues

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.4, 8.0
    • Fix Version/s: 7.4, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today we pass on the doc values update to the PendingDeletes
      when it's applied. This might cause issues with a rentention policy
      merge policy that will see a deleted document but not it's value on
      disk.
      This change moves back the PendingDeletes callback to flush time
      in order to be consistent with what is actually updated on disk.

      This change also makes sure we write values to disk on flush that
      are in the reader pool as well as extra best effort checks to drop
      fully deleted segments on flush, commit and getReader.

        Attachments

        1. LUCENE-8290.patch
          11 kB
          Simon Willnauer

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              simonw Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: