Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8282

Reduce boxing and unnecessary object creation in DV updates

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.4, 8.0
    • Fix Version/s: 7.4, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      DV updates used the boxed type Long to keep API generic. Yet, the missing
      type caused a lot of code duplication, boxing and unnecessary object creation.
      This change cuts over to type safe APIs using BytesRef and long (the primitive)

      In this change most of the code that is almost identical between binary and numeric
      is not shared reducing the maintenance overhead and likelihood of introducing bugs.

        Attachments

        1. LUCENE-8282.patch
          30 kB
          Simon Willnauer

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              simonw Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: