[LUCENE-828] Term's equals() throws ClassCastException if passed something other than a Term - ASF JIRA

Details

Type: Bug
Status: Resolved
Priority: Trivial
Resolution: Fixed
Affects Version/s: 2.1
Fix Version/s: None
Component/s: None
Labels:
None

Lucene Fields:

New, Patch Available

Description

Term.equals(Object) does a cast to Term without checking if the other object is a Term.

It's unlikely that this would ever crop up but it violates the implied contract of Object.equals().

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

termequals.patch

08/Mar/07 05:15

2 kB

Paul Cowan

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Paul Cowan added a comment - 08/Mar/07 05:15

Amendment to .equals() to deal with non-Term objects.

Also includes standard performance optimisation in the case that the two objects are identity-equal, and a test case (the last assertion of which fails on current trunk, but passes after patch is applies to Term).

Show

Paul Cowan added a comment - 08/Mar/07 05:15 Amendment to .equals() to deal with non-Term objects. Also includes standard performance optimisation in the case that the two objects are identity-equal, and a test case (the last assertion of which fails on current trunk, but passes after patch is applies to Term).

Hide

Permalink

Otis Gospodnetic added a comment - 16/Mar/07 15:23

Patch applied, thanks Paul!

Show

Otis Gospodnetic added a comment - 16/Mar/07 15:23 Patch applied, thanks Paul!

People

Assignee:

Unassigned

Reporter:

Paul Cowan

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

08/Mar/07 05:13

Updated:

16/Mar/07 15:23

Resolved:

16/Mar/07 15:23

Development

Agile

View on Board