[LUCENE-8191] merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.3, 8.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 04/Mar/18 15:29
• Updated: 28/Aug/22 15:26
• Resolved: 04/Mar/18 16:27

Description

Now that indexwriter checks offsets (LUCENE-7626), there is no difference between the two: A tokenstream that has brokenoffsets will fail regardless, only in a harder-to-debug way (e.g. some low level exception from indexwriter).

So I think we should just merge the two lists to reflect that: if it produces brokenOffsets, its broken.