[LUCENE-8152] Simplify conditionals in JoinUtil

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 7.3, 8.0
• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Horatiu Lazu
• Created: 02/Feb/18 00:30
• Updated: 28/Aug/22 15:25
• Resolved: 13/Feb/18 13:49

Description

The following could be simplified, on line 249:

int dvDocID = numericDocValues.docID();
if (dvDocID < doc) {
  dvDocID = numericDocValues.advance(doc);
}
long value;
if (dvDocID == doc) {
  value = numericDocValues.longValue();
} else {
  value = 0;
}

To:

long value = 0;
if (numericDocValues.advanceExact(doc)) {
  value = numericDocValues.longValue();
}

Issue Links

• breaks: SOLR-11974 TestCollapseQParserPlugin.testStringCollapse() failure
• links to: GitHub Pull Request #319