Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-814

javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant replace'

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.2
    • general/build
    • None
    • Windows, Cygwin

    • Patch Available

    Description

      "ant javacc" in Windows/Cygwin generates files with wrong line endings (\r or \r\n instead of *Nix's \n).
      I managed to get rid of those using perl -p -e 's/(\r\n|\n|\r)/\n/g'
      Some useful info on line ending issues is in http://en.wikipedia.org/wiki/Newline

      After wasting some time to get rid of those, I modified javacc-QueryParser build.xml task to take care of that.
      So now QueryParser files created with "ant javacc" are fixed (if required) to have \n as line ends.

      Should probably do that also for the other javacc targets: javacc-HTMLParser and javacc-StandardAnalyzer

      Attachments

        1. 814.javacc.line.ends.patch
          1 kB
          Doron Cohen
        2. LUCENE-814.txt
          2 kB
          Steven Parkes
        3. 814.javacc.fixcrlf.common-build.patch
          0.7 kB
          Doron Cohen
        4. LUCENE-814.txt
          0.9 kB
          Steven Parkes
        5. 814.javacc.fixcrlf.common-build.patch
          0.8 kB
          Doron Cohen
        6. 814.javacc.fixcrlf.common-build.patch
          0.9 kB
          Doron Cohen
        7. 814.javacc.fixcrlf.common-build.patch
          0.5 kB
          Doron Cohen

        Activity

          People

            doronc Doron Cohen
            doronc Doron Cohen
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: