[LUCENE-8103] QueryValueSource should use TwoPhaseIterator

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Component/s: modules/other
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 18/Dec/17 17:05
• Updated: 28/Aug/22 15:23
• Resolved: 15/Mar/20 15:58

Description

QueryValueSource (in "queries" module) is a ValueSource representation of a Query; the score is the value. It ought to try to use a TwoPhaseIterator from the query if it can be offered. This will prevent possibly expensive advancing beyond documents that we aren't interested in.

Issue Links

• causes: LUCENE-9762 DoubleValuesSource.fromQuery can fail when doc visited twice
• links to: GitHub Pull Request #1343