Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8050

PerFieldDocValuesFormat's merge should not grab field DVF if DocValuesType.NONE

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.3
    • Fix Version/s: 8.6
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Since LUCENE-7456 (Lucene 6.3), PerFieldDocValuesFormat delegates the merge to the actual field DVF's merge. Great, but unfortunately it will call getDocValuesFormatForField on all fields (in FieldInfos) even those that have no DocValues (DocValuesType.NONE). It won't ultimately actually write anything to those DVFs but there may be some overhead and furthermore it's now more awkward to write a subclass of PFDVF that deliberately throws an exception from getDocValuesFormatForField for some fields.

      AFAICT this appears to be a non-issue for PerFieldPostingsFormat's merge because it's use of MultiFields filters out IndexOptions.NONE

        Attachments

        1. LUCENE_8050.patch
          2 kB
          David Smiley

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m