Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8049

IndexWriter.getMergingSegments should return a Set, not Collection

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.2
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      IndexWriter.getMergingSegments is called by the MergePolicy so that it can filter out segments to merge using mergingSegments.contains(seg). The implementation is a HashSet, thankfully but the declared type of this method ought to be defined as a Set as well.

        Attachments

          Activity
          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment