[LUCENE-8041] All Fields.terms(fld) impls should be O(1) not O(log(N))

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 06/Nov/17 21:46
• Updated: 22/Sep/22 14:09
• Resolved: 03/Dec/19 14:41

Description

I've seen apps that have a good number of fields – hundreds. The O(log(N)) of TreeMap definitely shows up in a profiler; sometimes 20% of search time, if I recall. There are many Field implementations that are impacted... in part because Fields is the base class of FieldsProducer.

As an aside, I hope Fields to go away some day; FieldsProducer should be TermsProducer and not have an iterator of fields. If DocValuesProducer doesn't have this then why should the terms index part of our API have it? If we did this then the issue here would be a simple transition to a HashMap.

Or maybe we can switch to HashMap and relax the definition of Fields.iterator to not necessarily be sorted?

Perhaps the fix can be a relatively simple conversion over to LinkedHashMap in many cases if we can assume when we initialize these internal maps that we consume them in sorted order to begin with.

Issue Links

• is a parent of: LUCENE-9045 Do not use TreeMap/TreeSet in BlockTree and PerFieldPostingsFormat
• is duplicated by: LUCENE-8800 FieldsReader#terms poor performance on a index with many field names sharing common prefix
• relates to: LUCENE-9078 Term vectors options should not be configurable per-doc