[LUCENE-8034] SpanNotWeight returns wrong results due to integer overflow

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.2, 8.0
• Component/s: core/query/scoring, core/search
• Labels: newbie patch
• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Hari Menon
• Created: 03/Nov/17 20:45
• Updated: 22/Dec/17 08:31
• Resolved: 22/Nov/17 23:08

Description

In SpanNotQuery, there is an acceptance condition:

if (candidate.endPosition() + post <= excludeSpans.startPosition()) {
    return AcceptStatus.YES;
}

This overflows in case `candidate.endPosition() + post > Integer.MAX_VALUE`. I have a fix for this which I am working on. Basically I am flipping the add to a subtract.