[LUCENE-7968] AnalyzingSuggester's comparator compares incorrectly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.1, 8.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 13/Sep/17 00:26
• Updated: 28/Aug/22 15:19
• Resolved: 17/Sep/17 15:49

Description

Found by LUCENE-7966, but we should fix here separate.

Currently the tie-break case of this comparator is buggy when hasPayloads=false, as it assigns negative lengths to the BytesRefs being compared. The current BytesRef.compareTo simply silently returns false in this case, hiding the bug.

Issue Links

• relates to: LUCENE-7966 build mr-jar and use some java 9 methods if available