[LUCENE-7946] CharTermAttributeImpl.setLength missing bounds check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.1, 8.0
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 31/Aug/17 05:13
• Updated: 28/Aug/22 15:18
• Resolved: 01/Sep/17 03:37

Description

CharTermAttribute.setLength partially checks for out of bounds values (exceeds term buffer array size) but doesn't check for negative values.

This can be confusing as then the negative length will only fail or misbehave much later, for example with the first iteration of LUCENE-7940. It fails later only when we call toString() afterwards.