Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7922

Remove packed FST support?

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • None
    • None
    • None
    • None
    • New

    Description

      I've been looking at the FST code we have today. Complex to read, even more complex to modify. I think it could benefit if we cleaned it up a bit (there are a few issues out there already that mention this).

      The first baby step would be to remove the "packed" representation of FSTs – I searched the codebase and I don't see a single place where pack would actually be true. The overhead associated with node packing seems to be not worth it in practice (since most FSTs are already fairly small).

      It'd be a breaking API change, but it's probably something worth undertaking for 7.0, unless I'm missing some use cases.

      Attachments

        1. node.patch
          4 kB
          Dawid Weiss

        Issue Links

          Activity

            People

              dweiss Dawid Weiss
              dweiss Dawid Weiss
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: