[LUCENE-7922] Remove packed FST support?

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Lucene Fields: New
• Assignee: Dawid Weiss
• Reporter: Dawid Weiss
• Created: 09/Aug/17 12:04
• Updated: 28/Aug/22 15:17
• Resolved: 09/Aug/17 12:06

Description

I've been looking at the FST code we have today. Complex to read, even more complex to modify. I think it could benefit if we cleaned it up a bit (there are a few issues out there already that mention this).

The first baby step would be to remove the "packed" representation of FSTs – I searched the codebase and I don't see a single place where pack would actually be true. The overhead associated with node packing seems to be not worth it in practice (since most FSTs are already fairly small).

It'd be a breaking API change, but it's probably something worth undertaking for 7.0, unless I'm missing some use cases.

Issue Links

• is related to: LUCENE-7531 Remove packing support from FST