Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7859

PackedQuadCell.getTokenBytesNoLeaf bug when null BytesRef

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0
    • Component/s: modules/spatial-extras
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      PackedQuadCell.getTokenBytesNoLeaf and PackedQuadCell.getTokenBytesWithLeaf have a couple issues that were exposed in LUCENE-7845. One is that the WithLeaf version actually modifies the state (long term) which it shouldn't. Another is that if the BytesRef is null, it can compute a different result than if it's not null, which is definitely wrong.

      It appears that these problems are only revealing themselves in practice with the LUCENE-7845 optimization since there has been no PackedQuad test failure before, and RandomSpatialOpFuzzyPrefixTreeTest really hammers the prefix tree.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: