Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7815

Remove PostingsHighlighter in 7.0

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 7.0
    • modules/highlighter
    • None
    • New

    Description

      The UnifiedHighlighter is derived from the PostingsHighlighter, which should be quite obvious to anyone who cares to look at them. There is no feature in the PH that is not also present in the UH. The PH is marked as lucene.experimental so we may remove it in 7.0. The upgrade path is pretty easy given the API similarity. By removing the PH, the goal is to ease maintenance. Some issues lately have been applicable to both of these highlighters which is annoying to apply twice. In one case I forgot to. And of course there is user confusion by having both.

      What I propose to do in this issue is move CustomSeparatorBreakIterator and WholeBreakIterator out of the postingshighlight package into the uhighlight package (or perhaps add a common or util should future highlighters need them?). Then of course remove postingshighlight package.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dsmiley David Smiley
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment