Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1
    • Component/s: core/store
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      The copy operation in RAMDirectory(Directory) constructor can be used more generally to copy one directory to another. Why bound it only to RAMDirectory?. For example, I build index in RAMDirectory but I need it to persist in FSDirectory. I created a patch to solve it.

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        I agree, moving this up to Directory from RAMDirectory makes sense.

        The patch applies cleanly and all tests pass.

        I will make a small change to do the is.close/os.close in a "finally" clause, and then I'll commit it.

        Thanks Jiri!

        Show
        mikemccand Michael McCandless added a comment - I agree, moving this up to Directory from RAMDirectory makes sense. The patch applies cleanly and all tests pass. I will make a small change to do the is.close/os.close in a "finally" clause, and then I'll commit it. Thanks Jiri!
        Hide
        mikemccand Michael McCandless added a comment -

        OK I committed this. I added the try/finally and made some small changes to the javadoc.

        Thanks Jiri and keep the patches coming!

        Show
        mikemccand Michael McCandless added a comment - OK I committed this. I added the try/finally and made some small changes to the javadoc. Thanks Jiri and keep the patches coming!
        Hide
        mikemccand Michael McCandless added a comment -

        Closing all issues that were resolved for 2.1.

        Show
        mikemccand Michael McCandless added a comment - Closing all issues that were resolved for 2.1.

          People

          • Assignee:
            Unassigned
            Reporter:
            kuhn Jiri Kuhn
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development