Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7797

FSDirectory.listAll will always return empty array

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 7.0, 6.6
        • Component/s: core/store
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          FSDirector#listAll(Path)

          which invoke private method 

          FSDirector#listAll(Path, Set<String>)

          will always return empty array.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Indeed, the logic is backwards now. I was wondering how Lucene could possible be working, since listAll is used when opening a non-near-real-time DirectoryReader, but then I realized it's only the static FSDirectory.listAll(Path) that tickles this bug since the non-static version always passes pendingDeletes.

            Thank you for the patch w/ test case Atkins Chang ... I'll push soon.

            Show
            mikemccand Michael McCandless added a comment - Indeed, the logic is backwards now. I was wondering how Lucene could possible be working, since listAll is used when opening a non-near-real-time DirectoryReader , but then I realized it's only the static FSDirectory.listAll(Path) that tickles this bug since the non-static version always passes pendingDeletes . Thank you for the patch w/ test case Atkins Chang ... I'll push soon.
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 4cd83ea276a72a4e6a3a46a3dd49a84bffb07fe7 in lucene-solr's branch refs/heads/master from Mike McCandless
            [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4cd83ea ]

            LUCENE-7797: the static FSDirectory.listAll was always returning an empty array

            Show
            jira-bot ASF subversion and git services added a comment - Commit 4cd83ea276a72a4e6a3a46a3dd49a84bffb07fe7 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4cd83ea ] LUCENE-7797 : the static FSDirectory.listAll was always returning an empty array
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 8d3fb8ab59da5a1bd8d3f82385d0d16dc1e58a47 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
            [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d3fb8a ]

            LUCENE-7797: the static FSDirectory.listAll was always returning an empty array

            Show
            jira-bot ASF subversion and git services added a comment - Commit 8d3fb8ab59da5a1bd8d3f82385d0d16dc1e58a47 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d3fb8a ] LUCENE-7797 : the static FSDirectory.listAll was always returning an empty array
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Thank you Atkins Chang.

            Show
            mikemccand Michael McCandless added a comment - Thank you Atkins Chang .

              People

              • Assignee:
                Unassigned
                Reporter:
                atkinschang Atkins Chang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development