[LUCENE-7788] fail precommit on unparameterised log messages and examine for wasted work/objects

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Lucene Fields: New
• Assignee: Erick Erickson
• Reporter: Christine Poerschke
• Created: 19/Apr/17 11:34
• Updated: 28/Aug/22 15:13
• Resolved: 01/May/20 17:11

Description

SOLR-10415 would be removing existing unparameterised log.trace messages use and once that is in place then this ticket's one-line change would be for 'ant precommit' to reject any future unparameterised log.trace message use.

Issue Links

• fixes: SOLR-12301 Umbrella issue: paramaterize logging calls in Solr, use consistent naming conventions for the logger
• fixes: SOLR-10415 Within solr-core, debug/trace level logging should use parameterized log messages
• is related to: SOLR-12419 standardise solr/contrib (private) logger names
• is related to: SOLR-12557 standardise solr/core (private) logger names
• relates to: SOLR-11884 find/fix inefficiencies in our use of logging
• relates to: SOLR-12286 Wrap log instances in "if (LOG.isLevelEnabled) { log... }
• relates to: SOLR-10415 Within solr-core, debug/trace level logging should use parameterized log messages
• links to: GitHub Pull Request #1428