Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7787

Optimize HeatmapFacetCounter to detect Bits.MatchNoBits

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.6
    • Component/s: modules/spatial-extras
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      HeatmapFacetCounter should short-circuit when the docSet is instanceof Bits.MatchNoBits. This can save a ton of wasted time in relevant circumstances.

      (This development was funded by the Harvard Center for Geographic Analysis as part of the HHypermap project)

      1. LUCENE_7787.patch
        0.9 kB
        David Smiley

        Activity

        Hide
        dsmiley David Smiley added a comment -

        Very simple patch.

        Show
        dsmiley David Smiley added a comment - Very simple patch.
        Hide
        jpountz Adrien Grand added a comment -

        +1

        Do I get it right that it is already naturally optimized in master thanks to doc-value iterators?

        Show
        jpountz Adrien Grand added a comment - +1 Do I get it right that it is already naturally optimized in master thanks to doc-value iterators?
        Hide
        dsmiley David Smiley added a comment -

        HeatmapFacetCounter in spatial-extras does not use DocValues; it is a Terms index approach wherein the terms form a regular 2D grid.

        Show
        dsmiley David Smiley added a comment - HeatmapFacetCounter in spatial-extras does not use DocValues; it is a Terms index approach wherein the terms form a regular 2D grid.
        Hide
        jpountz Adrien Grand added a comment -

        So this could be merged to master as well? Sorry, maybe I just got confused because the fix version was set to 6.6 only but you actually intend to merge it to both master and 6.x?

        Show
        jpountz Adrien Grand added a comment - So this could be merged to master as well? Sorry, maybe I just got confused because the fix version was set to 6.6 only but you actually intend to merge it to both master and 6.x?
        Hide
        dsmiley David Smiley added a comment -

        Yes indeed; I added 'master' to the Fix Version; sorry for confusion. For I don't know how long I've only put the lowest applicable release version into the Fix Version as it's kinda implied that master always gets changes but I suppose there are rare exceptions.

        Show
        dsmiley David Smiley added a comment - Yes indeed; I added 'master' to the Fix Version; sorry for confusion. For I don't know how long I've only put the lowest applicable release version into the Fix Version as it's kinda implied that master always gets changes but I suppose there are rare exceptions.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7d57d63375ee8b69c08b01f32bb950d16bd46751 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7d57d63 ]

        LUCENE-7787: HeatmapFacetCounter Bits.MatchNoBits optimization

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7d57d63375ee8b69c08b01f32bb950d16bd46751 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7d57d63 ] LUCENE-7787 : HeatmapFacetCounter Bits.MatchNoBits optimization
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4b3328d2dfa8ece0573204926262d79ba1f942ea in lucene-solr's branch refs/heads/branch_6x from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b3328d ]

        LUCENE-7787: HeatmapFacetCounter Bits.MatchNoBits optimization

        (cherry picked from commit 7d57d63)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4b3328d2dfa8ece0573204926262d79ba1f942ea in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b3328d ] LUCENE-7787 : HeatmapFacetCounter Bits.MatchNoBits optimization (cherry picked from commit 7d57d63)

          People

          • Assignee:
            dsmiley David Smiley
            Reporter:
            dsmiley David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development