Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7782

OfflineSorter.getWriter should pass number of items it will write

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      When OfflineSorter needs to write a new file, either a temp file or the final sorted output file, it calls getWriter. There is a default impl, but experts can override it to create their own writers.

      It would be helpful to pass the total item count that will be written to this file when calling getWriter because then the (expert) user has a little more information which can be useful when creating the temp or final file.

      It's low cost for OfflineSorter to track this.

      1. LUCENE-7782.patch
        7 kB
        Michael McCandless

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Simple patch.

        Show
        mikemccand Michael McCandless added a comment - Simple patch.
        Hide
        jpountz Adrien Grand added a comment -

        +1

        Show
        jpountz Adrien Grand added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 00f0c3022baa0b7f0ffc293aff4daa450ce6432f in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=00f0c30 ]

        LUCENE-7782: OfflineSorter now passes the number of items it will write to getWriter

        Show
        jira-bot ASF subversion and git services added a comment - Commit 00f0c3022baa0b7f0ffc293aff4daa450ce6432f in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=00f0c30 ] LUCENE-7782 : OfflineSorter now passes the number of items it will write to getWriter
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cc31db3dfbb3bdf8e6a3b9328c523d9f992daa7c in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cc31db3 ]

        LUCENE-7782: OfflineSorter now passes the number of items it will write to getWriter

        Show
        jira-bot ASF subversion and git services added a comment - Commit cc31db3dfbb3bdf8e6a3b9328c523d9f992daa7c in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cc31db3 ] LUCENE-7782 : OfflineSorter now passes the number of items it will write to getWriter

          People

          • Assignee:
            mikemccand Michael McCandless
            Reporter:
            mikemccand Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development