Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7777

ByteBlockPool.readBytes incorrectly throws AIOOBE if length > 32768

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.6, 6.5.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I'm using Lucene's OfflineSorter to sort a large data set, and some of the items in the set are > 32 KB in length, which tickled a bug in its readBytes.

      1. LUCENE-7777.patch
        6 kB
        Michael McCandless

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Patch w/ test case showing the issue, and the fix; I also tried to simplify both the append and readBytes implementations...

        Show
        mikemccand Michael McCandless added a comment - Patch w/ test case showing the issue, and the fix; I also tried to simplify both the append and readBytes implementations...
        Hide
        jpountz Adrien Grand added a comment -

        +1 the new append/readBytes impls are much easier to read to me now

        Show
        jpountz Adrien Grand added a comment - +1 the new append/readBytes impls are much easier to read to me now
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e386ec973b8a4ec2de2bfc43f51df511a365d60f in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e386ec9 ]

        LUCENE-7777: fix AIOOBE from ByteBlockPool.readBytes when byte block exceeds 32 KB

        Show
        jira-bot ASF subversion and git services added a comment - Commit e386ec973b8a4ec2de2bfc43f51df511a365d60f in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e386ec9 ] LUCENE-7777 : fix AIOOBE from ByteBlockPool.readBytes when byte block exceeds 32 KB
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5987a2a7361188db5187c62042aba1ef41ce905a in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5987a2a ]

        LUCENE-7777: fix AIOOBE from ByteBlockPool.readBytes when byte block exceeds 32 KB

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5987a2a7361188db5187c62042aba1ef41ce905a in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5987a2a ] LUCENE-7777 : fix AIOOBE from ByteBlockPool.readBytes when byte block exceeds 32 KB
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks Adrien Grand.

        Show
        mikemccand Michael McCandless added a comment - Thanks Adrien Grand .
        Hide
        dweiss Dawid Weiss added a comment -

        Much simpler to read. Nice issue number too.

        Show
        dweiss Dawid Weiss added a comment - Much simpler to read. Nice issue number too.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e4630c6182b61502604a22d98915c6790bb256eb in lucene-solr's branch refs/heads/branch_6_5 from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4630c6 ]

        LUCENE-7777: fix AIOOBE from ByteBlockPool.readBytes when byte block exceeds 32 KB

        Show
        jira-bot ASF subversion and git services added a comment - Commit e4630c6182b61502604a22d98915c6790bb256eb in lucene-solr's branch refs/heads/branch_6_5 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4630c6 ] LUCENE-7777 : fix AIOOBE from ByteBlockPool.readBytes when byte block exceeds 32 KB

          People

          • Assignee:
            mikemccand Michael McCandless
            Reporter:
            mikemccand Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development