Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7763

remove outdated comment in IndexWriterConfig.setIndexSort javadocs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 6.5
    • 6.5.1
    • None
    • None
    • New

    Description

      马可阳 wrote on the dev mailing list:

      ...
      code comment out of date: Note that newly flushed segments will remain unsorted
      ...
      It is comment of method : setIndexSort in IndexWriterConfig.java. Code link is below:
      https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
      since issue “LUCENE-7579: sort segments at flush too” is already merged into code, this
      comment is out of date.
      ...

      The comment is included in the javadocs:
      http://lucene.apache.org/core/6_5_0/core/org/apache/lucene/index/IndexWriterConfig.html#setIndexSort-org.apache.lucene.search.Sort-

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cpoerschke Christine Poerschke
            cpoerschke Christine Poerschke
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment