Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7763

remove outdated comment in IndexWriterConfig.setIndexSort javadocs

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.5
    • Fix Version/s: 6.5.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      马可阳 wrote on the dev mailing list:

      ...
      code comment out of date: Note that newly flushed segments will remain unsorted
      ...
      It is comment of method : setIndexSort in IndexWriterConfig.java. Code link is below:
      https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
      since issue “LUCENE-7579: sort segments at flush too” is already merged into code, this
      comment is out of date.
      ...

      The comment is included in the javadocs:
      http://lucene.apache.org/core/6_5_0/core/org/apache/lucene/index/IndexWriterConfig.html#setIndexSort-org.apache.lucene.search.Sort-

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 413555651da61b764c05313b37b44339581be02d in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4135556 ]

          LUCENE-7763: Remove outdated comment in IndexWriterConfig.setIndexSort javadocs.
          (马可阳 via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 413555651da61b764c05313b37b44339581be02d in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4135556 ] LUCENE-7763 : Remove outdated comment in IndexWriterConfig.setIndexSort javadocs. (马可阳 via Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1ae3cf4c5696594b9f3338522a4f6d86306f2804 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1ae3cf4 ]

          LUCENE-7763: Remove outdated comment in IndexWriterConfig.setIndexSort javadocs.
          (马可阳 via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1ae3cf4c5696594b9f3338522a4f6d86306f2804 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1ae3cf4 ] LUCENE-7763 : Remove outdated comment in IndexWriterConfig.setIndexSort javadocs. (马可阳 via Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7ab4291fb298bd2a0272950be96a3c70df0f9187 in lucene-solr's branch refs/heads/branch_6_5 from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7ab4291 ]

          LUCENE-7763: Remove outdated comment in IndexWriterConfig.setIndexSort javadocs.
          (马可阳 via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7ab4291fb298bd2a0272950be96a3c70df0f9187 in lucene-solr's branch refs/heads/branch_6_5 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7ab4291 ] LUCENE-7763 : Remove outdated comment in IndexWriterConfig.setIndexSort javadocs. (马可阳 via Christine Poerschke)

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development