> can you explain this...
> + /** Sub class ad hoc IndexReader coupling */
> + protected IndexSearcher()
> + }
> "reader" is package protected, so any out of package subclass that uses this
> constructor is pretty much screwed right? .. how is would this constructor be useful?
Sorry, that is an old artifact from a hack, not ment for the patch. I'll refresh the patch.
> i don't think it's safe to make those methods final though ... there may not be any
> subclasses in the tree, but that's no garuntee there aren't users with their own subclasses
> (consider all the people who might have written a proxy cache like you are but needed
> to override all of those methods to do so)
I personally think they should change their code to override only the non-final method call. Anything else would be overkill. At least that is what I concluded while making these changes, hence the finals. But if it is final or not does not matter much to me. It is all good as long all Hits-returining method calls pass by that last non-final method in this patch.