Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7739

FindBugs: boxing/unboxing to parse a primitive

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.5
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      As suggested in LUCENE-3973, we could add findbugs as a precommit hook if we get the number of issues reported down to zero.

      1. LUCENE-7739.patch
        37 kB
        Daniel Jelinski
      2. LUCENE-7739.patch
        34 kB
        Daniel Jelinski

        Issue Links

          Activity

          Hide
          djelinski Daniel Jelinski added a comment -

          Patch to address "boxing/unboxing to parse a primitive"; removes unneeded heap allocations when parsing strings. Should be fairly easy to review, as the new version is functionally equivalent.

          Show
          djelinski Daniel Jelinski added a comment - Patch to address "boxing/unboxing to parse a primitive"; removes unneeded heap allocations when parsing strings. Should be fairly easy to review, as the new version is functionally equivalent.
          Hide
          djelinski Daniel Jelinski added a comment -

          Missed source .jj files in the original patch, updating.

          Show
          djelinski Daniel Jelinski added a comment - Missed source .jj files in the original patch, updating.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e7b87f5b79f744252bca79356c2bcdeaed503e74 in lucene-solr's branch refs/heads/master from Mike McCandless
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e7b87f5 ]

          LUCENE-7739: Fix places where we unnecessarily boxed while parsing a numeric value according to FindBugs

          Show
          jira-bot ASF subversion and git services added a comment - Commit e7b87f5b79f744252bca79356c2bcdeaed503e74 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e7b87f5 ] LUCENE-7739 : Fix places where we unnecessarily boxed while parsing a numeric value according to FindBugs
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2f939af2cc8d00392d5bb76aa0374d489296c4a6 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2f939af ]

          LUCENE-7739: Fix places where we unnecessarily boxed while parsing a numeric value according to FindBugs

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2f939af2cc8d00392d5bb76aa0374d489296c4a6 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2f939af ] LUCENE-7739 : Fix places where we unnecessarily boxed while parsing a numeric value according to FindBugs
          Hide
          mikemccand Michael McCandless added a comment -

          Thanks Daniel Jelinski, I pushed this; but we still need to fold this into ant precommit somehow.

          Show
          mikemccand Michael McCandless added a comment - Thanks Daniel Jelinski , I pushed this; but we still need to fold this into ant precommit somehow.

            People

            • Assignee:
              Unassigned
              Reporter:
              djelinski Daniel Jelinski
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development