Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7701

Refactor grouping collectors

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 7.0
    • None
    • None
    • New

    Description

      Grouping currently works via abstract collectors, which need to be overridden for each way of defining a group - currently we have two, 'term' (based on SortedDocValues) and 'function' (based on ValueSources). These collectors all have a lot of repeated code, and means that if you want to implement your own group definitions, you need to override four or five different classes.

      This would be easier to deal with if instead the 'group selection' code was abstracted out into a single interface, and the various collectors were changed to concrete implementations.

      Attachments

        1. LUCENE-7701.patch
          134 kB
          Alan Woodward
        2. LUCENE-7701.patch
          218 kB
          Alan Woodward

        Issue Links

          Activity

            People

              Unassigned Unassigned
              romseygeek Alan Woodward
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Slack

                  Issue deployment