Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This ticket splits out the lucene part of the changes proposed in SOLR-10046 for a conversation on whether or not the OneMergeWrappingMergePolicy class would best be located in Lucene or in Solr.

      (As an aside, the proposed use of java.util.function.UnaryOperator causes ant documentation-lint to fail, I have created LUCENE-7689 separately for that.)

      1. LUCENE-7688.patch
        9 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment -

          Attaching snapshot of the lucene portion of https://github.com/apache/lucene-solr/pull/144 as of this afternoon.

          Show
          cpoerschke Christine Poerschke added a comment - Attaching snapshot of the lucene portion of https://github.com/apache/lucene-solr/pull/144 as of this afternoon.
          Hide
          mikemccand Michael McCandless added a comment -

          Thanks Christine Poerschke, can you give an example of what this class would be used for? Thanks.

          Show
          mikemccand Michael McCandless added a comment - Thanks Christine Poerschke , can you give an example of what this class would be used for? Thanks.
          Hide
          k317h Keith Laban added a comment -

          Hi Michael, the main use case is easily overaload the wrapForMerge function in OneMerge without having write a whole merge policy. The required ticket SOLR-10046 uses it to wrap the CodecReader with one that has access to FeildCache and will add docvalues when merging segments if required. But generally you can do anything you can do by wrapping a CodeReader, add/remove fields, etc.

          Show
          k317h Keith Laban added a comment - Hi Michael, the main use case is easily overaload the wrapForMerge function in OneMerge without having write a whole merge policy. The required ticket SOLR-10046 uses it to wrap the CodecReader with one that has access to FeildCache and will add docvalues when merging segments if required. But generally you can do anything you can do by wrapping a CodeReader, add/remove fields, etc.
          Hide
          mikemccand Michael McCandless added a comment -

          OK thanks Keith Laban and Christine Poerschke, this makes sense and sounds useful, +1.

          Show
          mikemccand Michael McCandless added a comment - OK thanks Keith Laban and Christine Poerschke , this makes sense and sounds useful, +1.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6f9acb51549f8edd5164f8db26d72f83448d0fc1 in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f9acb5 ]

          LUCENE-7688: Add OneMergeWrappingMergePolicy class. (Keith Laban, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6f9acb51549f8edd5164f8db26d72f83448d0fc1 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f9acb5 ] LUCENE-7688 : Add OneMergeWrappingMergePolicy class. (Keith Laban, Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 180614c1491a7e8ffa7b5aba5bab0ad646e2d5f4 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=180614c ]

          LUCENE-7688: Add OneMergeWrappingMergePolicy class. (Keith Laban, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 180614c1491a7e8ffa7b5aba5bab0ad646e2d5f4 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=180614c ] LUCENE-7688 : Add OneMergeWrappingMergePolicy class. (Keith Laban, Christine Poerschke)
          Hide
          cpoerschke Christine Poerschke added a comment -

          Thanks Keith!

          Show
          cpoerschke Christine Poerschke added a comment - Thanks Keith!

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development