Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7685

Remove equals/rewrite hacks from block join queries

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.5
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      These queries try to ensure that rewritten queries are equal to the original query by keeping around the original query that was used to instantiate the join query. However this does not buy anything, and could even prevent two queries that rewrite to the same form to be considered equals.

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch.

        Show
        jpountz Adrien Grand added a comment - Here is a patch.
        Hide
        mikemccand Michael McCandless added a comment -

        +1

        What on earth did this comment mean?

        This makes rewritten query equal the original, so that user does not have to .rewrite() their query before searching:
        

        Why would a user have to (in the past) manually rewrite their query before searching ...

        Show
        mikemccand Michael McCandless added a comment - +1 What on earth did this comment mean? This makes rewritten query equal the original, so that user does not have to .rewrite() their query before searching: Why would a user have to (in the past) manually rewrite their query before searching ...
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        +1

        Show
        martijn.v.groningen Martijn van Groningen added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c2f061d7cbcdfdd8dc77215e84e4a3682b2b5f0a in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c2f061d ]

        LUCENE-7685: Remove equals/rewrite hacks from block join queries.

        Show
        jira-bot ASF subversion and git services added a comment - Commit c2f061d7cbcdfdd8dc77215e84e4a3682b2b5f0a in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c2f061d ] LUCENE-7685 : Remove equals/rewrite hacks from block join queries.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e092d4f344432cf56b0059027a3365d30227a925 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e092d4f ]

        LUCENE-7685: Remove equals/rewrite hacks from block join queries.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e092d4f344432cf56b0059027a3365d30227a925 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e092d4f ] LUCENE-7685 : Remove equals/rewrite hacks from block join queries.

          People

          • Assignee:
            Unassigned
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development