Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7667

BKDReader could call grow on larger increments

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.5
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently, we only call grow() on leaf nodes. We could make it grow with larger increments by calling grow() on the number of leaf cells under the current node when the relation is CELL_INSIDE_QUERY (logic that we already have for point count estimations).

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch. The IntNRQ benchmark does not show a speedup but I don't think it means this change is never useful as ranges in this benchmark tend to match lots of documents so runtime is dominated by the time it takes to fill the bitset.

        Show
        jpountz Adrien Grand added a comment - Here is a patch. The IntNRQ benchmark does not show a speedup but I don't think it means this change is never useful as ranges in this benchmark tend to match lots of documents so runtime is dominated by the time it takes to fill the bitset.
        Hide
        mikemccand Michael McCandless added a comment -

        +1, nice.

        Show
        mikemccand Michael McCandless added a comment - +1, nice.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3592af20e7925f0d84ade29c303f06355b5b92c0 in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3592af2 ]

        LUCENE-7667: BKDReader could call IntersectVisitor.grow on larger increments.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3592af20e7925f0d84ade29c303f06355b5b92c0 in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3592af2 ] LUCENE-7667 : BKDReader could call IntersectVisitor.grow on larger increments.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8e7bf58a130fefa39473edeacad460ff1f7fbdfa in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8e7bf58 ]

        LUCENE-7667: BKDReader could call IntersectVisitor.grow on larger increments.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8e7bf58a130fefa39473edeacad460ff1f7fbdfa in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8e7bf58 ] LUCENE-7667 : BKDReader could call IntersectVisitor.grow on larger increments.

          People

          • Assignee:
            Unassigned
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development