Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7638

Optimize graph query produced by QueryBuilder


    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.5
    • None
    • None
    • New, Patch Available


      The QueryBuilder creates a graph query when the underlying TokenStream contains token with PositionLengthAttribute greater than 1.
      These TokenStreams are in fact graphs (lattice to be more precise) where synonyms can span on multiple terms.
      Currently the graph query is built by visiting all the path of the graph TokenStream. For instance if you have a synonym like "ny, new york" and you search for "new york city", the query builder would produce two pathes:
      "new york city", "ny city"
      This can quickly explode when the number of multi terms synonyms increase.
      The query "ny ny" for instance would produce 4 pathes and so on.
      For boolean queries with should or must clauses it should be more efficient to build a boolean query that merges all the intersections in the graph. So instead of "new york city", "ny city" we could produce:
      "+((+new +york) ny) +city"

      The attached patch is a proposal to do that instead of the all path solution.
      The patch transforms multi terms synonyms in graph query for each intersection in the graph. This is not done in this patch but we could also create a specialized query that gives equivalent scores to multi terms synonyms like the SynonymQuery does for single term synonyms.
      For phrase query this patch does not change the current behavior but we could also use the new method to create optimized graph SpanQuery.

      mattweber I think this patch could optimize a lot of cases where multiple muli-terms synonyms are present in a single request. Could you take a look ?


        1. LUCENE-7638.patch
          48 kB
          Jim Ferenczi
        2. LUCENE-7638.patch
          16 kB
          Jim Ferenczi



            Unassigned Unassigned
            jim.ferenczi Jim Ferenczi
            0 Vote for this issue
            9 Start watching this issue