Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7637

TermInSetQuery should require that all terms come from the same field

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.5
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spin-off from LUCENE-7624. Requiring that all terms are in the same field would make things simpler and more consistent with other queries. It might also make it easier to improve this query in the future since other similar queries like AutomatonQuery also work on the per-field basis. The only downside is that querying terms across multiple fields would be less efficient, but this does not seem to be a common use-case.

      1. LUCENE-7637.patch
        23 kB
        Adrien Grand

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch.

        Show
        jpountz Adrien Grand added a comment - Here is a patch.
        Hide
        mikemccand Michael McCandless added a comment -

        +1

        I just found a small typo: // ne need to check --> // no need to check.

        Show
        mikemccand Michael McCandless added a comment - +1 I just found a small typo: // ne need to check --> // no need to check .
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 43874fc5b5c7fe37c70524693ea2db4ef0e01f95 in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=43874fc ]

        LUCENE-7637: Require that all terms of a TermsQuery come from the same field.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 43874fc5b5c7fe37c70524693ea2db4ef0e01f95 in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=43874fc ] LUCENE-7637 : Require that all terms of a TermsQuery come from the same field.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5c2f5bd028d370f43fbeee07fc6d197449609af3 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c2f5bd ]

        LUCENE-7637: Require that all terms of a TermsQuery come from the same field.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5c2f5bd028d370f43fbeee07fc6d197449609af3 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c2f5bd ] LUCENE-7637 : Require that all terms of a TermsQuery come from the same field.
        Hide
        mikemccand Michael McCandless added a comment -

        Can this be resolved now?

        Show
        mikemccand Michael McCandless added a comment - Can this be resolved now?
        Hide
        paul.elschot@xs4all.nl Paul Elschot added a comment -

        There is a pull request from me at LUCENE-7624 that landed there because that issue was mentioned in the commit message.

        Show
        paul.elschot@xs4all.nl Paul Elschot added a comment - There is a pull request from me at LUCENE-7624 that landed there because that issue was mentioned in the commit message.
        Hide
        jpountz Adrien Grand added a comment -

        Can this be resolved now?

        Indeed, thanks for the reminder!

        Show
        jpountz Adrien Grand added a comment - Can this be resolved now? Indeed, thanks for the reminder!

          People

          • Assignee:
            Unassigned
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development