Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      AnalyzingInfixSuggester uses IndexSorter, which was in the misc module when the dependency was added in LUCENE-5477. IndexSorter is in core now, though, so this dependency can be removed.

      lucene/misc/src/java/org/apache/lucene/index/Sorter.java became lucene/core/src/java/org/apache/lucene/index/Sorter.java as part of LUCENE-6766

      1. LUCENE-7612.patch
        2 kB
        Alan Woodward

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 77828f764c84bbe97571c8679ab523163d2da0e5 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77828f7 ]

        LUCENE-7612: Remove suggester dependency on misc

        Show
        jira-bot ASF subversion and git services added a comment - Commit 77828f764c84bbe97571c8679ab523163d2da0e5 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77828f7 ] LUCENE-7612 : Remove suggester dependency on misc
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f3306786a13bda596a60cada45406e6f6a88724f in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f330678 ]

        LUCENE-7612: Remove suggester dependency on misc

        Show
        jira-bot ASF subversion and git services added a comment - Commit f3306786a13bda596a60cada45406e6f6a88724f in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f330678 ] LUCENE-7612 : Remove suggester dependency on misc
        Hide
        mikemccand Michael McCandless added a comment -

        +1 to remove the stale dep ... thanks Alan Woodward!

        Show
        mikemccand Michael McCandless added a comment - +1 to remove the stale dep ... thanks Alan Woodward !
        Hide
        cpoerschke Christine Poerschke added a comment -

        ... I think the maven and eclipse templates will pick this up automatically?

        Yes, for maven that looks to be the case, not sure about eclipse though.

        ant clean-maven-build
        ant get-maven-poms
        cp maven-build/lucene/suggest/pom.xml before-lucene-suggest-pom.xml
        
        git apply LUCENE-7612.patch
        
        ant clean-maven-build
        ant get-maven-poms
        cp maven-build/lucene/suggest/pom.xml after-lucene-suggest-pom.xml
        
        diff -c before-lucene-suggest-pom.xml after-lucene-suggest-pom.xml
        ...
              </dependency>
              <dependency>
                <groupId>org.apache.lucene</groupId>
        -       <artifactId>lucene-misc</artifactId>
        -     </dependency>
        -     <dependency>
        -       <groupId>org.apache.lucene</groupId>
                <artifactId>lucene-queries</artifactId>
              </dependency>
        ...
        
        Show
        cpoerschke Christine Poerschke added a comment - ... I think the maven and eclipse templates will pick this up automatically? Yes, for maven that looks to be the case, not sure about eclipse though. ant clean-maven-build ant get-maven-poms cp maven-build/lucene/suggest/pom.xml before-lucene-suggest-pom.xml git apply LUCENE-7612.patch ant clean-maven-build ant get-maven-poms cp maven-build/lucene/suggest/pom.xml after-lucene-suggest-pom.xml diff -c before-lucene-suggest-pom.xml after-lucene-suggest-pom.xml ... </dependency> <dependency> <groupId>org.apache.lucene</groupId> - <artifactId>lucene-misc</artifactId> - </dependency> - <dependency> - <groupId>org.apache.lucene</groupId> <artifactId>lucene-queries</artifactId> </dependency> ...
        Hide
        romseygeek Alan Woodward added a comment -

        Patch, editing the suggest module's build.xml and the IDEA config. I think the maven and eclipse templates will pick this up automatically?

        Show
        romseygeek Alan Woodward added a comment - Patch, editing the suggest module's build.xml and the IDEA config. I think the maven and eclipse templates will pick this up automatically?

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development