Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7611

Make suggester module use LongValuesSource

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This allows us to remove the suggester module's dependency on the queries module.

      1. LUCENE-7611.patch
        23 kB
        Alan Woodward
      2. LUCENE-7611.patch
        22 kB
        Alan Woodward

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 322ad889604688db9d22ba7dfa1e389a01e34857 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=322ad88 ]

        LUCENE-7611: Remove queries javadoc link from suggester help page

        Show
        jira-bot ASF subversion and git services added a comment - Commit 322ad889604688db9d22ba7dfa1e389a01e34857 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=322ad88 ] LUCENE-7611 : Remove queries javadoc link from suggester help page
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 67261d2fb515f255e05c138281ab6c6b71d66716 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=67261d2 ]

        LUCENE-7611: Remove unnecessary Exception wrapping from DocumentValueSourceDictionary

        Show
        jira-bot ASF subversion and git services added a comment - Commit 67261d2fb515f255e05c138281ab6c6b71d66716 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=67261d2 ] LUCENE-7611 : Remove unnecessary Exception wrapping from DocumentValueSourceDictionary
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 31db19d3e4e0dec89ece38ef27577e8b668c93c2 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=31db19d ]

        LUCENE-7611: Remove unnecessary Exception wrapping from DocumentValueSourceDictionary

        Show
        jira-bot ASF subversion and git services added a comment - Commit 31db19d3e4e0dec89ece38ef27577e8b668c93c2 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=31db19d ] LUCENE-7611 : Remove unnecessary Exception wrapping from DocumentValueSourceDictionary
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8f4fee3ad1c0027587d0de96f59cf61b2df67bc8 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f4fee3 ]

        LUCENE-7611: Remove queries dependency from suggester module

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8f4fee3ad1c0027587d0de96f59cf61b2df67bc8 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f4fee3 ] LUCENE-7611 : Remove queries dependency from suggester module
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1a95c5acd0f69efb1a24b2c980a289289e703758 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a95c5a ]

        LUCENE-7611: Suggester uses LongValuesSource in place of ValueSource

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1a95c5acd0f69efb1a24b2c980a289289e703758 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a95c5a ] LUCENE-7611 : Suggester uses LongValuesSource in place of ValueSource
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d268055ca3f6fc6885940bdca39bed36b8f558fc in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d268055 ]

        LUCENE-7611: Suggester uses LongValuesSource in place of ValueSource

        Show
        jira-bot ASF subversion and git services added a comment - Commit d268055ca3f6fc6885940bdca39bed36b8f558fc in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d268055 ] LUCENE-7611 : Suggester uses LongValuesSource in place of ValueSource
        Hide
        romseygeek Alan Woodward added a comment -

        Updated patch, moving the constant() helper to LongValuesSource.

        Show
        romseygeek Alan Woodward added a comment - Updated patch, moving the constant() helper to LongValuesSource.
        Hide
        jpountz Adrien Grand added a comment -

        +1 Maybe the constant helper should move to core? I imagine there will be more use-cases for it.

        Show
        jpountz Adrien Grand added a comment - +1 Maybe the constant helper should move to core? I imagine there will be more use-cases for it.
        Hide
        romseygeek Alan Woodward added a comment -

        Patch, to be applied after the patches on LUCENE-7609 and LUCENE-7610

        Show
        romseygeek Alan Woodward added a comment - Patch, to be applied after the patches on LUCENE-7609 and LUCENE-7610

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development