Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7610

Migrate facets module from ValueSource to Double/LongValuesSource

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Unfortunately this doesn't allow us to break the facets dependency on the queries module, because facets also uses TermsQuery - perhaps this should move to core as well?

      1. LUCENE-7610.patch
        42 kB
        Alan Woodward
      2. LUCENE-7610.patch
        31 kB
        Alan Woodward

        Activity

        Hide
        romseygeek Alan Woodward added a comment -

        Patch, to be applied after the patch on LUCENE-7609

        Show
        romseygeek Alan Woodward added a comment - Patch, to be applied after the patch on LUCENE-7609
        Hide
        jpountz Adrien Grand added a comment -

        +1 but I think we should remove the deprecated getQuery methods as they are not expected to be called by users of the facets module.

        Show
        jpountz Adrien Grand added a comment - +1 but I think we should remove the deprecated getQuery methods as they are not expected to be called by users of the facets module.
        Hide
        romseygeek Alan Woodward added a comment -

        Updated patch removing the deprecated methods and adding javadoc to the methods on Double/LongRange directly.

        Show
        romseygeek Alan Woodward added a comment - Updated patch removing the deprecated methods and adding javadoc to the methods on Double/LongRange directly.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a238610bab1499b340fde8e120f02b33233b40e1 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a238610 ]

        LUCENE-7610: Deprecate ValueSource methods in facets module

        Show
        jira-bot ASF subversion and git services added a comment - Commit a238610bab1499b340fde8e120f02b33233b40e1 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a238610 ] LUCENE-7610 : Deprecate ValueSource methods in facets module
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 713b65d1dcc80c1fe147a5bf999e1a88b63b9dce in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=713b65d ]

        LUCENE-7610: Deprecate ValueSource methods in facets module

        Show
        jira-bot ASF subversion and git services added a comment - Commit 713b65d1dcc80c1fe147a5bf999e1a88b63b9dce in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=713b65d ] LUCENE-7610 : Deprecate ValueSource methods in facets module
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ce8b678ba19a53c43033a235bdca54e5a68adcc8 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ce8b678 ]

        LUCENE-7610: Remove deprecated facet ValueSource methods

        Show
        jira-bot ASF subversion and git services added a comment - Commit ce8b678ba19a53c43033a235bdca54e5a68adcc8 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ce8b678 ] LUCENE-7610 : Remove deprecated facet ValueSource methods

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development