Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7547

JapaneseTokenizerFactory opens dictionary file but never closes it again

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5.4, 6.4, 7.0
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      JapaneseTokenizerFactory opens dictionary file in line 130
      InputStream stream = loader.openResource(userDictionaryPath);
      but never closes it again.
      This leads to too many open files after after a couple of query executions.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bd6c0523c2de09250ff07db6e4a21227bd143ea2 in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bd6c052 ]

        LUCENE-7547: close the dictionary file so we don't leak file handles

        Show
        jira-bot ASF subversion and git services added a comment - Commit bd6c0523c2de09250ff07db6e4a21227bd143ea2 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bd6c052 ] LUCENE-7547 : close the dictionary file so we don't leak file handles
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ecff2519b830e2436df835635e2395efe86dff1e in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ecff251 ]

        LUCENE-7547: close the dictionary file so we don't leak file handles

        Show
        jira-bot ASF subversion and git services added a comment - Commit ecff2519b830e2436df835635e2395efe86dff1e in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ecff251 ] LUCENE-7547 : close the dictionary file so we don't leak file handles
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks Markus, I pushed a fix.

        Show
        mikemccand Michael McCandless added a comment - Thanks Markus , I pushed a fix.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 28d405c2d581c2ecbda89afd33e8b05a313a8e17 in lucene-solr's branch refs/heads/branch_5_5 from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=28d405c ]

        LUCENE-7547: close the dictionary file so we don't leak file handles

        Show
        jira-bot ASF subversion and git services added a comment - Commit 28d405c2d581c2ecbda89afd33e8b05a313a8e17 in lucene-solr's branch refs/heads/branch_5_5 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=28d405c ] LUCENE-7547 : close the dictionary file so we don't leak file handles

          People

          • Assignee:
            Unassigned
            Reporter:
            nabucko Markus
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development