Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7520

WeightedSpanTermExtractor should not rewrite MultiTermQuery all the time

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently WeightedSpanTermExtractor will rewrite MultiTermQuery regardless of the field being requested for highlighting. In some case like SOLR-2216, It can be costly and cause TooManyClauses exception for no reason.

        Issue Links

          Activity

          Hide
          caomanhdat Cao Manh Dat added a comment -

          Patch for this issue.

          Show
          caomanhdat Cao Manh Dat added a comment - Patch for this issue.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e1b06938b4b0442b18878e59fde57e29ca641499 in lucene-solr's branch refs/heads/master from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e1b0693 ]

          LUCENE-7520: WSTE shouldn't expand MTQ if its field doesn't match filter

          Show
          jira-bot ASF subversion and git services added a comment - Commit e1b06938b4b0442b18878e59fde57e29ca641499 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e1b0693 ] LUCENE-7520 : WSTE shouldn't expand MTQ if its field doesn't match filter
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 167013c44102e1d5679235b94370f59dcbc92726 in lucene-solr's branch refs/heads/branch_6x from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=167013c ]

          LUCENE-7520: WSTE shouldn't expand MTQ if its field doesn't match filter

          (cherry picked from commit e1b0693)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 167013c44102e1d5679235b94370f59dcbc92726 in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=167013c ] LUCENE-7520 : WSTE shouldn't expand MTQ if its field doesn't match filter (cherry picked from commit e1b0693)
          Hide
          dsmiley David Smiley added a comment -

          Thanks Dat!

          I tweaked the early-return logic to happen a bit earlier to avoid the needless invocation of getLeafReader() which can be rather expensive (sometimes needing to index the content).

          I put the CHANGES.txt entry into "Improvements" because it's debatable if this is a bug fix or an optimization.

          Show
          dsmiley David Smiley added a comment - Thanks Dat! I tweaked the early-return logic to happen a bit earlier to avoid the needless invocation of getLeafReader() which can be rather expensive (sometimes needing to index the content). I put the CHANGES.txt entry into "Improvements" because it's debatable if this is a bug fix or an optimization.
          Hide
          caomanhdat Cao Manh Dat added a comment -

          Thanks, that's will be nice.

          Show
          caomanhdat Cao Manh Dat added a comment - Thanks, that's will be nice.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Closing after 6.3.0 release.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              caomanhdat Cao Manh Dat
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development