Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.3
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff from SOLR-8370 where we display Similarity class in use in the Admin UI.

      SweetSpotSimilarity does not provide a toString method, so it will incorreclty print ClassicSimilarity.

        Activity

        Hide
        janhoy Jan Høydahl added a comment -

        Patch.

        There are many config variables. Could perhaps be smarter in detecting whether baseline of hyperbolic is in use and print only the active set of params?

        Show
        janhoy Jan Høydahl added a comment - Patch. There are many config variables. Could perhaps be smarter in detecting whether baseline of hyperbolic is in use and print only the active set of params?
        Hide
        jpountz Adrien Grand added a comment -

        +1 to the patch. I think being exhaustive is fine.

        Show
        jpountz Adrien Grand added a comment - +1 to the patch. I think being exhaustive is fine.
        Hide
        janhoy Jan Høydahl added a comment -

        Ok, I'll commit on thursday if no objections

        Show
        janhoy Jan Høydahl added a comment - Ok, I'll commit on thursday if no objections
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c4b4830ac1c984e54e23c374ec7b83e598c7fc4b in lucene-solr's branch refs/heads/master from Jan Høydahl
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c4b4830 ]

        LUCENE-7496: Better toString for SweetSpotSimilarity

        Show
        jira-bot ASF subversion and git services added a comment - Commit c4b4830ac1c984e54e23c374ec7b83e598c7fc4b in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c4b4830 ] LUCENE-7496 : Better toString for SweetSpotSimilarity
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 22b0d5f4d21acaa3a28da5dec0654ecf102198c3 in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=22b0d5f ]

        LUCENE-7496: Better toString for SweetSpotSimilarity

        (cherry picked from commit c4b4830)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 22b0d5f4d21acaa3a28da5dec0654ecf102198c3 in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=22b0d5f ] LUCENE-7496 : Better toString for SweetSpotSimilarity (cherry picked from commit c4b4830)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            janhoy Jan Høydahl
            Reporter:
            janhoy Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development