Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7490

SimpleQueryParser should parse "*" as MatchAllDocsQuery

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.2.1
    • Fix Version/s: master (7.0), 6.3
    • Component/s: modules/queryparser
    • Labels:
      None

      Description

      It would be beneficial for SimpleQueryString to parse as a MatchAllDocsQuery, rather than a "field:*" query.

      Related discussion on the Elasticsearch project about this: https://github.com/elastic/elasticsearch/issues/10632

        Activity

        Hide
        dakrone Lee Hinman added a comment -

        Attaching patch with small fix and unit test

        Show
        dakrone Lee Hinman added a comment - Attaching patch with small fix and unit test
        Hide
        mikemccand Michael McCandless added a comment -

        I think this is reasonable? And the patch looks great, thanks Lee Hinman.

        Show
        mikemccand Michael McCandless added a comment - I think this is reasonable? And the patch looks great, thanks Lee Hinman .
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4ae1643f66bb2d90b04b1dd7c12c55d9c24bcd33 in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4ae1643 ]

        LUCENE-7490: SimpleQueryParser now parses '*' as MatchAllDocsQuery

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4ae1643f66bb2d90b04b1dd7c12c55d9c24bcd33 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4ae1643 ] LUCENE-7490 : SimpleQueryParser now parses '*' as MatchAllDocsQuery
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 67d206c665dd476501d696474a393d6588e7c56d in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=67d206c ]

        LUCENE-7490: SimpleQueryParser now parses '*' as MatchAllDocsQuery

        Show
        jira-bot ASF subversion and git services added a comment - Commit 67d206c665dd476501d696474a393d6588e7c56d in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=67d206c ] LUCENE-7490 : SimpleQueryParser now parses '*' as MatchAllDocsQuery
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks Lee Hinman!

        Show
        mikemccand Michael McCandless added a comment - Thanks Lee Hinman !
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            dakrone Lee Hinman
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development