[LUCENE-7446] Fix back-compat version check in addVersion helper script

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.5.4, 5.6, 6.0.2, 6.1.1, 6.2.1, 6.3, 7.0
• Lucene Fields: New, Patch Available
• Assignee: Anshum Gupta
• Reporter: Anshum Gupta
• Created: 11/Sep/16 21:29
• Updated: 28/Aug/22 15:03
• Resolved: 13/Sep/16 15:57

Description

As part of the 5.5.3 post-release process, I was trying to bump up the number to 5.5.4 on the release branch but ran into the following error:

Traceback (most recent call last):
  File "dev-tools/scripts/addVersion.py", line 246, in <module>
    main()
  File "dev-tools/scripts/addVersion.py", line 221, in main
    if current_version.is_back_compat_with(c.version):
  File "/Users/anshumgupta/workspace/lucene-solr/dev-tools/scripts/scriptutil.py", line 75, in is_back_compat_with
    raise Exception('Back compat check disallowed for newer version: %s < %s' % (self, other))
Exception: Back compat check disallowed for newer version: 5.5.3 < 5.5.4

I think the check is wrong and should be reversed. I'll post a patch that I used to work around this but would be good to have more eyes on this before I commit this.

steve_rowe: Can you take a look at the patch as I guess you added this recently.