Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7436

MinHashFilter has package-local constructor and constants

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.2
    • Fix Version/s: master (7.0), 6.3, 6.2.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Trying to use the MinHashFilter outside of Lucene/Solr. Was it intentional that the constructor and useful defaults are package-private? Seems like an oversight to me, correct me if I'm wrong.

        Activity

        Hide
        softwaredoug Doug Turnbull added a comment -
        Show
        softwaredoug Doug Turnbull added a comment - Fix is here https://github.com/apache/lucene-solr/pull/78
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks; I don't think this was intentional. I'll commit shortly.

        Show
        mikemccand Michael McCandless added a comment - Thanks; I don't think this was intentional. I'll commit shortly.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c6ab0e0f1ba03fc74f740c2807acd3bd356090ea in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c6ab0e0 ]

        LUCENE-7436: make constructor and default settings public for MinMashFilter

        Show
        jira-bot ASF subversion and git services added a comment - Commit c6ab0e0f1ba03fc74f740c2807acd3bd356090ea in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c6ab0e0 ] LUCENE-7436 : make constructor and default settings public for MinMashFilter
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7834fc1d5d5e328681c9b69514176641d95447c9 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7834fc1 ]

        LUCENE-7436: make constructor and default settings public for MinMashFilter

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7834fc1d5d5e328681c9b69514176641d95447c9 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7834fc1 ] LUCENE-7436 : make constructor and default settings public for MinMashFilter
        Hide
        mikemccand Michael McCandless added a comment -

        Thank you Doug Turnbull!

        Show
        mikemccand Michael McCandless added a comment - Thank you Doug Turnbull !
        Hide
        mikemccand Michael McCandless added a comment -

        Reopen for back port to 6.2.1.

        Show
        mikemccand Michael McCandless added a comment - Reopen for back port to 6.2.1.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 84dfd1937e20418d330e3b96d6c6b8ccfc202c27 in lucene-solr's branch refs/heads/branch_6_2 from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=84dfd19 ]

        LUCENE-7436: make constructor and default settings public for MinMashFilter

        Show
        jira-bot ASF subversion and git services added a comment - Commit 84dfd1937e20418d330e3b96d6c6b8ccfc202c27 in lucene-solr's branch refs/heads/branch_6_2 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=84dfd19 ] LUCENE-7436 : make constructor and default settings public for MinMashFilter
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.2.1 release

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.2.1 release

          People

          • Assignee:
            Unassigned
            Reporter:
            softwaredoug Doug Turnbull
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development