Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7417

Highlighting fails for MultiPhraseQuery's with one clause

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.1, 5.x, 5.5.2
    • Fix Version/s: 6.3, 5.5.4, 6.2.1
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      This bug is the same issue as LUCENE-7231, just for MultiPhraseQuery instead of PhraseQuery. The fix is the same as well. To reproduce, change the test that was committed for LUCENE-7231 to use a MultiPhraseQuery. It results in the same error

      java.lang.IllegalArgumentException: Less than 2 subSpans.size():1

      I have a patch including a test against branch_5.x, it just needs to go through legal before I can post it.

        Activity

        Hide
        Thomas Kappler Thomas Kappler added a comment -

        Patch against 5.x as of 2016-09-05

        Show
        Thomas Kappler Thomas Kappler added a comment - Patch against 5.x as of 2016-09-05
        Hide
        Thomas Kappler Thomas Kappler added a comment -

        I got clearance from legal now and attached a patch, including test, against the current 5.x branch. Let me know if you need anything else, I'm happy to help.

        Show
        Thomas Kappler Thomas Kappler added a comment - I got clearance from legal now and attached a patch, including test, against the current 5.x branch. Let me know if you need anything else, I'm happy to help.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3966f998214e8d34593ccde2db70c5cc49966443 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3966f99 ]

        LUCENE-7417: Highlighter WSTE didn't handle single-term MultiPhraseQuery.
        Also updated to Java 5 for-each in this method.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3966f998214e8d34593ccde2db70c5cc49966443 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3966f99 ] LUCENE-7417 : Highlighter WSTE didn't handle single-term MultiPhraseQuery. Also updated to Java 5 for-each in this method.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 514bb1bbc19be939b2e23be3a1d647342b60945f in lucene-solr's branch refs/heads/branch_6x from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=514bb1b ]

        LUCENE-7417: Highlighter WSTE didn't handle single-term MultiPhraseQuery.
        Also updated to Java 5 for-each in this method.

        (cherry picked from commit 3966f99)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 514bb1bbc19be939b2e23be3a1d647342b60945f in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=514bb1b ] LUCENE-7417 : Highlighter WSTE didn't handle single-term MultiPhraseQuery. Also updated to Java 5 for-each in this method. (cherry picked from commit 3966f99)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9a8ff64260102702b293b87de6914e438f439c31 in lucene-solr's branch refs/heads/branch_5x from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a8ff64 ]

        LUCENE-7417: Highlighter WSTE didn't handle single-term MultiPhraseQuery.
        Also updated to Java 5 for-each in this method.

        (cherry picked from commit 514bb1b)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9a8ff64260102702b293b87de6914e438f439c31 in lucene-solr's branch refs/heads/branch_5x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a8ff64 ] LUCENE-7417 : Highlighter WSTE didn't handle single-term MultiPhraseQuery. Also updated to Java 5 for-each in this method. (cherry picked from commit 514bb1b)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7350d14a9f8a2bedf07d8ae7b89cf67884ca879e in lucene-solr's branch refs/heads/branch_5_5 from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7350d14 ]

        LUCENE-7417: Highlighter WSTE didn't handle single-term MultiPhraseQuery.
        Also updated to Java 5 for-each in this method.

        (cherry picked from commit 9a8ff64)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7350d14a9f8a2bedf07d8ae7b89cf67884ca879e in lucene-solr's branch refs/heads/branch_5_5 from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7350d14 ] LUCENE-7417 : Highlighter WSTE didn't handle single-term MultiPhraseQuery. Also updated to Java 5 for-each in this method. (cherry picked from commit 9a8ff64)
        Hide
        dsmiley David Smiley added a comment -

        Thanks for the patch Thomas!

        BTW in my commit I also updated some looping in this method to use Java 5 for-each style.

        Show
        dsmiley David Smiley added a comment - Thanks for the patch Thomas! BTW in my commit I also updated some looping in this method to use Java 5 for-each style.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit af03a210c9eee1806de944e7ceff3835eaf79870 in lucene-solr's branch refs/heads/branch_5_5 from Anshum Gupta
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=af03a21 ]

        LUCENE-7417: Move CHANGES entry from 5.5.3 to 5.5.4

        Show
        jira-bot ASF subversion and git services added a comment - Commit af03a210c9eee1806de944e7ceff3835eaf79870 in lucene-solr's branch refs/heads/branch_5_5 from Anshum Gupta [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=af03a21 ] LUCENE-7417 : Move CHANGES entry from 5.5.3 to 5.5.4
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Re-opened to backport to 6.2.1

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Re-opened to backport to 6.2.1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cddeb9dc3c8322b4149b910f509a93be37f5c17b in lucene-solr's branch refs/heads/branch_6_2 from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cddeb9d ]

        LUCENE-7417: Highlighter WSTE didn't handle single-term MultiPhraseQuery.
        Also updated to Java 5 for-each in this method.

        (cherry picked from commit 3966f99)

        (cherry picked from commit 514bb1b)

        Show
        jira-bot ASF subversion and git services added a comment - Commit cddeb9dc3c8322b4149b910f509a93be37f5c17b in lucene-solr's branch refs/heads/branch_6_2 from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cddeb9d ] LUCENE-7417 : Highlighter WSTE didn't handle single-term MultiPhraseQuery. Also updated to Java 5 for-each in this method. (cherry picked from commit 3966f99) (cherry picked from commit 514bb1b)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.2.1 release

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.2.1 release

          People

          • Assignee:
            dsmiley David Smiley
            Reporter:
            Thomas Kappler Thomas Kappler
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development