Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7385

SpanScorer's assert message strings should reference spans.toString()

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer to this.toString(). I'm pretty confident the intention was for this to actually be spans.toString(), not "this" which is a SpanScorer that doesn't even have a custom toString. It was probably correct once but after some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).

        Attachments

          Activity

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment