Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 6.2
-
Component/s: core/search
-
Labels:None
-
Lucene Fields:New
Description
SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer to this.toString(). I'm pretty confident the intention was for this to actually be spans.toString(), not "this" which is a SpanScorer that doesn't even have a custom toString. It was probably correct once but after some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Commit efef37bb6795ed3be33056025a88d2cd4b848604 in lucene-solr's branch refs/heads/master from David Smiley
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efef37b ]
LUCENE-7385: Improve/fix assert messages in SpanScorer.
Commit 6e99ed3013d4bc53168d22560a0d9ac5f9db1cfb in lucene-solr's branch refs/heads/branch_6x from David Smiley
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e99ed3 ]
LUCENE-7385: Improve/fix assert messages in SpanScorer.
(cherry picked from commit efef37b)
Commit 5c4b7173a8535b76a96a32bdba79d8b89be14dc7 in lucene-solr's branch refs/heads/master from David Smiley
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c4b717 ]
LUCENE-7385: fix location of CHANGES.txt entry in master (branch_6x is good)
Bulk close resolved issues after 6.2.0 release.
Using Spans.toString sounds more correct to me indeed.