Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7385

SpanScorer's assert message strings should reference spans.toString()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 6.2
    • core/search
    • None
    • New

    Description

      SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer to this.toString(). I'm pretty confident the intention was for this to actually be spans.toString(), not "this" which is a SpanScorer that doesn't even have a custom toString. It was probably correct once but after some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).

      Attachments

        1. LUCENE_7385.patch
          2 kB
          David Smiley

        Activity

          People

            dsmiley David Smiley
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: