[LUCENE-7385] SpanScorer's assert message strings should reference spans.toString()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 6.2
• Component/s: core/search
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 18/Jul/16 02:50
• Updated: 26/Aug/16 13:59
• Resolved: 19/Jul/16 02:11

Description

SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer to this.toString(). I'm pretty confident the intention was for this to actually be spans.toString(), not "this" which is a SpanScorer that doesn't even have a custom toString. It was probably correct once but after some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).