Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7385

SpanScorer's assert message strings should reference spans.toString()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer to this.toString(). I'm pretty confident the intention was for this to actually be spans.toString(), not "this" which is a SpanScorer that doesn't even have a custom toString. It was probably correct once but after some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Using Spans.toString sounds more correct to me indeed.

        Show
        jpountz Adrien Grand added a comment - Using Spans.toString sounds more correct to me indeed.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit efef37bb6795ed3be33056025a88d2cd4b848604 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efef37b ]

        LUCENE-7385: Improve/fix assert messages in SpanScorer.

        Show
        jira-bot ASF subversion and git services added a comment - Commit efef37bb6795ed3be33056025a88d2cd4b848604 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efef37b ] LUCENE-7385 : Improve/fix assert messages in SpanScorer.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6e99ed3013d4bc53168d22560a0d9ac5f9db1cfb in lucene-solr's branch refs/heads/branch_6x from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e99ed3 ]

        LUCENE-7385: Improve/fix assert messages in SpanScorer.
        (cherry picked from commit efef37b)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6e99ed3013d4bc53168d22560a0d9ac5f9db1cfb in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e99ed3 ] LUCENE-7385 : Improve/fix assert messages in SpanScorer. (cherry picked from commit efef37b)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5c4b7173a8535b76a96a32bdba79d8b89be14dc7 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c4b717 ]

        LUCENE-7385: fix location of CHANGES.txt entry in master (branch_6x is good)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5c4b7173a8535b76a96a32bdba79d8b89be14dc7 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c4b717 ] LUCENE-7385 : fix location of CHANGES.txt entry in master (branch_6x is good)
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            dsmiley David Smiley
            Reporter:
            dsmiley David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development