Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This seems to be something of a relic. It's still used in Solr, but I think it makes more sense to move it directly into the ExplainAugmenter there rather than having it in Lucene itself.

      1. LUCENE-7360.patch
        2 kB
        Alan Woodward

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.
        Hide
        romseygeek Alan Woodward added a comment -

        Thanks for the review Adrien!

        Show
        romseygeek Alan Woodward added a comment - Thanks for the review Adrien!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f3dcd467ff391ae7988cbc0576cc2c1bdb5caaa5 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f3dcd46 ]

        LUCENE-7360: Remove Explanation.toHtml()

        Show
        jira-bot ASF subversion and git services added a comment - Commit f3dcd467ff391ae7988cbc0576cc2c1bdb5caaa5 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f3dcd46 ] LUCENE-7360 : Remove Explanation.toHtml()
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 23119db3606732986d31c6e44ec26fbbde79ef75 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=23119db ]

        LUCENE-7360: Explanation.toHtml() is deprecated

        Show
        jira-bot ASF subversion and git services added a comment - Commit 23119db3606732986d31c6e44ec26fbbde79ef75 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=23119db ] LUCENE-7360 : Explanation.toHtml() is deprecated
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d33ad81d69ed8f96a2e7b8b00f4616c979378cd4 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d33ad81 ]

        LUCENE-7360: Explanation.toHtml() is deprecated

        Show
        jira-bot ASF subversion and git services added a comment - Commit d33ad81d69ed8f96a2e7b8b00f4616c979378cd4 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d33ad81 ] LUCENE-7360 : Explanation.toHtml() is deprecated
        Hide
        romseygeek Alan Woodward added a comment -

        Good idea, and I'll just deprecate the method in 6.x.

        Show
        romseygeek Alan Woodward added a comment - Good idea, and I'll just deprecate the method in 6.x.
        Hide
        jpountz Adrien Grand added a comment -

        +1 to the patch. Maybe add a quick note to the lucene/MIGRATE.txt?

        Show
        jpountz Adrien Grand added a comment - +1 to the patch. Maybe add a quick note to the lucene/MIGRATE.txt?
        Hide
        romseygeek Alan Woodward added a comment -

        Here's a patch against master.

        Show
        romseygeek Alan Woodward added a comment - Here's a patch against master.
        Hide
        jpountz Adrien Grand added a comment -

        +1

        Show
        jpountz Adrien Grand added a comment - +1

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development