Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.2
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      See http://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/3349

      The bug here is that we do this crazy copyFrom of all the index files without fsyncing it. So MockDirectoryWrapper treats it as corrupted.

      But while investigating I noticed that RAMdir is incredibly lenient, will happily truncate existing files and so on. I think we should fix that here too.

      1. LUCENE-7345.patch
        7 kB
        Michael McCandless
      2. LUCENE-7345.patch
        4 kB
        Michael McCandless
      3. LUCENE-7345.patch
        4 kB
        Robert Muir
      4. LUCENE-7345.patch
        4 kB
        Robert Muir

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 918acdfbc596a0e60bcac8dd921a7841f1c3045d in lucene-solr's branch refs/heads/master from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=918acdf ]

        LUCENE-7345: fix test bug so jenkins isn't on fire anymore

        Show
        jira-bot ASF subversion and git services added a comment - Commit 918acdfbc596a0e60bcac8dd921a7841f1c3045d in lucene-solr's branch refs/heads/master from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=918acdf ] LUCENE-7345 : fix test bug so jenkins isn't on fire anymore
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5193a05385280548bb58fba89ad273c930ca8612 in lucene-solr's branch refs/heads/branch_6x from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5193a05 ]

        LUCENE-7345: fix test bug so jenkins isn't on fire anymore

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5193a05385280548bb58fba89ad273c930ca8612 in lucene-solr's branch refs/heads/branch_6x from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5193a05 ] LUCENE-7345 : fix test bug so jenkins isn't on fire anymore
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f19db7e6f58c3469b859c3f0d405033d888384f8 in lucene-solr's branch refs/heads/branch_5x from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f19db7e ]

        LUCENE-7345: fix test bug so jenkins isn't on fire anymore

        Show
        jira-bot ASF subversion and git services added a comment - Commit f19db7e6f58c3469b859c3f0d405033d888384f8 in lucene-solr's branch refs/heads/branch_5x from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f19db7e ] LUCENE-7345 : fix test bug so jenkins isn't on fire anymore
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fe03fb721352a5cfad0878296f8e719a794600fe in lucene-solr's branch refs/heads/branch_5_5 from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fe03fb7 ]

        LUCENE-7345: fix test bug so jenkins isn't on fire anymore

        Show
        jira-bot ASF subversion and git services added a comment - Commit fe03fb721352a5cfad0878296f8e719a794600fe in lucene-solr's branch refs/heads/branch_5_5 from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fe03fb7 ] LUCENE-7345 : fix test bug so jenkins isn't on fire anymore
        Hide
        rcmuir Robert Muir added a comment -

        Also MockDirectoryWrapper.corruptFiles looks out of date. This one will just hit exception trying to do what it does in many circumstances.

        Show
        rcmuir Robert Muir added a comment - Also MockDirectoryWrapper.corruptFiles looks out of date. This one will just hit exception trying to do what it does in many circumstances.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0aec9dd248f6c1a2968d4f0588e759919d49ee99 in lucene-solr's branch refs/heads/master from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0aec9dd ]

        LUCENE-7345: Fix more bugs in horrible test

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0aec9dd248f6c1a2968d4f0588e759919d49ee99 in lucene-solr's branch refs/heads/master from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0aec9dd ] LUCENE-7345 : Fix more bugs in horrible test
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 331366a95ce9d5452d8454913247fe8c69ca33e7 in lucene-solr's branch refs/heads/branch_6x from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=331366a ]

        LUCENE-7345: Fix more bugs in horrible test

        Show
        jira-bot ASF subversion and git services added a comment - Commit 331366a95ce9d5452d8454913247fe8c69ca33e7 in lucene-solr's branch refs/heads/branch_6x from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=331366a ] LUCENE-7345 : Fix more bugs in horrible test
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5c3fcda73224b962799a49236b185af5afb6169b in lucene-solr's branch refs/heads/branch_5x from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c3fcda ]

        LUCENE-7345: Fix more bugs in horrible test

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5c3fcda73224b962799a49236b185af5afb6169b in lucene-solr's branch refs/heads/branch_5x from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5c3fcda ] LUCENE-7345 : Fix more bugs in horrible test
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c3e54b8881548cce473aa6b615aa98a5d37648c4 in lucene-solr's branch refs/heads/branch_5_5 from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c3e54b8 ]

        LUCENE-7345: Fix more bugs in horrible test

        Show
        jira-bot ASF subversion and git services added a comment - Commit c3e54b8881548cce473aa6b615aa98a5d37648c4 in lucene-solr's branch refs/heads/branch_5_5 from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c3e54b8 ] LUCENE-7345 : Fix more bugs in horrible test
        Hide
        mikemccand Michael McCandless added a comment -

        +1, thanks Robert Muir!

        Show
        mikemccand Michael McCandless added a comment - +1, thanks Robert Muir !
        Hide
        mikemccand Michael McCandless added a comment -

        Here's a test + fix for MDW failing to corrupt files in some cases (caused by LUCENE-6171), which confounded the TestBoolean2 fixing.

        Show
        mikemccand Michael McCandless added a comment - Here's a test + fix for MDW failing to corrupt files in some cases (caused by LUCENE-6171 ), which confounded the TestBoolean2 fixing.
        Hide
        mikemccand Michael McCandless added a comment -

        Another iteration, this time remove MDW's leniency when it hits unexpected IOException when trying to corrumpt unsync'd files.

        Show
        mikemccand Michael McCandless added a comment - Another iteration, this time remove MDW's leniency when it hits unexpected IOException when trying to corrumpt unsync'd files.
        Hide
        rcmuir Robert Muir added a comment -

        Can we include the IOE in those exceptions so its not lost? Otherwise +1

        Show
        rcmuir Robert Muir added a comment - Can we include the IOE in those exceptions so its not lost? Otherwise +1
        Hide
        mikemccand Michael McCandless added a comment -

        Can we include the IOE in those exceptions so its not lost?

        Woops, definitely! I'll fix that and push.

        Show
        mikemccand Michael McCandless added a comment - Can we include the IOE in those exceptions so its not lost? Woops, definitely! I'll fix that and push.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4c630b2216aee06687d62259e8998f3fcbf766d1 in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c630b2 ]

        LUCENE-7345: make sure MDW's efforts to corrumpt un-sync'd files is successful

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4c630b2216aee06687d62259e8998f3fcbf766d1 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c630b2 ] LUCENE-7345 : make sure MDW's efforts to corrumpt un-sync'd files is successful
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0a0865b2c671e2951bde0bc07a2f4ef73314ed4f in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0a0865b ]

        LUCENE-7345: make sure MDW's efforts to corrumpt un-sync'd files is successful

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0a0865b2c671e2951bde0bc07a2f4ef73314ed4f in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0a0865b ] LUCENE-7345 : make sure MDW's efforts to corrumpt un-sync'd files is successful
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c311eb1b7ed72731cb7bd49e7fa3fcc23ddd7c04 in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c311eb1 ]

        LUCENE-7345: RAMDirectory now enforces write-once as well

        Show
        jira-bot ASF subversion and git services added a comment - Commit c311eb1b7ed72731cb7bd49e7fa3fcc23ddd7c04 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c311eb1 ] LUCENE-7345 : RAMDirectory now enforces write-once as well
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 07920c4fdaaa12255fc3700459043018ad73af0e in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=07920c4 ]

        LUCENE-7345: RAMDirectory now enforces write-once as well

        Show
        jira-bot ASF subversion and git services added a comment - Commit 07920c4fdaaa12255fc3700459043018ad73af0e in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=07920c4 ] LUCENE-7345 : RAMDirectory now enforces write-once as well
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks Robert Muir.

        Show
        mikemccand Michael McCandless added a comment - Thanks Robert Muir .
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 113afcf024b7aea8cb992c16be7179d5f77d117a in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=113afcf ]

        LUCENE-7345: MDW now disables VirusCheckingFS while trying to corrupt files

        Show
        jira-bot ASF subversion and git services added a comment - Commit 113afcf024b7aea8cb992c16be7179d5f77d117a in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=113afcf ] LUCENE-7345 : MDW now disables VirusCheckingFS while trying to corrupt files
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b338a0c0f0062794306f11d53941aad04c4622ae in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b338a0c ]

        LUCENE-7345: MDW now disables VirusCheckingFS while trying to corrupt files

        Show
        jira-bot ASF subversion and git services added a comment - Commit b338a0c0f0062794306f11d53941aad04c4622ae in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b338a0c ] LUCENE-7345 : MDW now disables VirusCheckingFS while trying to corrupt files
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development