Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This is a cleanup task to simplify and trim dead code from GeoPointField's query classes. Much of the relation logic in LatLonPoint can also be applied to GeoPointField's CellComparator class eliminating the need to carry its own separate relation methods.

      1. LUCENE-7343.patch
        33 kB
        Nicholas Knize

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Nicholas Knize can this be closed now?

        Show
        mikemccand Michael McCandless added a comment - Nicholas Knize can this be closed now?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fc68bd90e6fa3f8ed364f522f997fe6efd50a8b7 in lucene-solr's branch refs/heads/branch_6x from Nicholas Knize
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc68bd9 ]

        LUCENE-7343: Cleanup GeoPoint by sharing relation logic and removing stale code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit fc68bd90e6fa3f8ed364f522f997fe6efd50a8b7 in lucene-solr's branch refs/heads/branch_6x from Nicholas Knize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc68bd9 ] LUCENE-7343 : Cleanup GeoPoint by sharing relation logic and removing stale code.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fb3480b807149ef2777e3e12eeaf925a5622efe2 in lucene-solr's branch refs/heads/master from Nicholas Knize
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fb3480b ]

        LUCENE-7343: Cleanup GeoPoint by sharing relation logic and removing stale code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit fb3480b807149ef2777e3e12eeaf925a5622efe2 in lucene-solr's branch refs/heads/master from Nicholas Knize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fb3480b ] LUCENE-7343 : Cleanup GeoPoint by sharing relation logic and removing stale code.
        Hide
        nknize Nicholas Knize added a comment -

        First iteration patch:

        • Eliminates dead code from GeoPointTermsEnum left over from the legacy numeric implementation
        • Simplifies CellComparator by squashing separate within, crosses methods into a single relate method
        • GeoPointDistanceQuery uses haversine sortKey approach similar to LatLonPointDistanceQuery
        Show
        nknize Nicholas Knize added a comment - First iteration patch: Eliminates dead code from GeoPointTermsEnum left over from the legacy numeric implementation Simplifies CellComparator by squashing separate within , crosses methods into a single relate method GeoPointDistanceQuery uses haversine sortKey approach similar to LatLonPointDistanceQuery

          People

          • Assignee:
            Unassigned
            Reporter:
            nknize Nicholas Knize
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development